Wait for ephemeral container #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
|
|
javaducky
suggested changes
Jul 18, 2022
There was a problem hiding this comment.
Recommend using Act to run linter locally. There are some additional linting failures to cause your changes to fail upon merge.
act --job run-golangci
We should probably update our Github Actions to run the run-golangci job on creation of PRs rather than upon merge to main.
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
wait-for-ephemeral-container
branch
from
483874c
to
5af50ad
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
javaducky
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for waiting for ephemeral container to be running
closes #60