Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build with latest k6 due to incompatibility with grpc lib #39

Closed
mstoykov opened this issue Jun 15, 2022 · 2 comments · Fixed by #40
Closed

Can't build with latest k6 due to incompatibility with grpc lib #39

mstoykov opened this issue Jun 15, 2022 · 2 comments · Fixed by #40

Comments

@mstoykov
Copy link
Contributor

K6 did update to the latest (at the time gRPC) release and I just found out that this extensions doesn't build with that due to weaveworks/common#240 .

I am wondering if somebody on the loki team can not look into testing this and maybe get this PR merged 🤞

I don't know if loki updates gRPC lib regularly but that will block them as well :(
@chaudum
Copy link
Collaborator

chaudum commented Jun 20, 2022

Loki uses google.golang.org/grcp v1.45.0, whereas this weaveworks/common PR updates to v1.34.0.

https://github.com/grafana/loki/blob/a1c72ad562229cbd5d9fcd0e1075f3e80a6a3745/go.mod#L328-L329

https://github.com/weaveworks/common/pull/240/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R37

chaudum added a commit that referenced this issue Jun 20, 2022
@chaudum
Update k6 to v0.38.4-0.20220615141125-556747fbe585
496eafe 
This commit updates k6 to main branch, because k6 updated
weaveworks/common, which would break the build of this extension with
the next k6 release.

Fixes #39

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum mentioned this issue Jun 20, 2022
Merged
@mstoykov
Copy link
Contributor Author

I kind of hoped that we can push this to be merged upstream so that we don't have to replace the gRPC version 😬

chaudum added a commit that referenced this issue Jun 22, 2022
@chaudum
Update k6 to v0.38.4-0.20220615141125-556747fbe585
aed9abf 
This commit updates k6 to main branch, because k6 updated
weaveworks/common, which would break the build of this extension with
the next k6 release.

Fixes #39

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update k6 to v0.38.4-0.20220615141125-556747fbe585 grafana/xk6-loki
2 participants
@chaudum @mstoykov