Send correct payload when doing JSON push requests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/issue-9
branch
2 times, most recently
from
01c400a
to
1ddb2c2
Compare
chaudum
force-pushed
the
chaudum/issue-9
branch
from
1ddb2c2
to
0b42ace
Compare
This implementation is rather inefficient as it depends on the `Batch` struct that is optimized for Protobuf usage. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
```console $ go test -bench BenchmarkEncode -benchmem -benchtime 15s goos: linux goarch: amd64 pkg: github.com/grafana/xk6-loki cpu: Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz BenchmarkEncode/encode_protobuf-8 79969106 238.6 ns/op 232 B/op 2 allocs/op BenchmarkEncode/encode_json-8 3477244 5355 ns/op 3384 B/op 50 allocs/op PASS ok github.com/grafana/xk6-loki 43.172s ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/issue-9
branch
from
0b42ace
to
22f8877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is not very efficient, as it makes use of the
Batchstruct that is designed for the usage with Protobufs.Signed-off-by: Christian Haudum christian.haudum@gmail.com