Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom metrics for read scenario #26

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

vlad-diachenko
Copy link
Contributor

implemented logic to report custom k6 metrics based on response stats for instant and range queries

client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@chaudum
Copy link
Collaborator

chaudum commented Feb 4, 2022

Can you please also add the metrics (+ the push metrics) to the README?

@vlad-diachenko
Copy link
Contributor Author

Can you please also add the metrics (+ the push metrics) to the README?

@chaudum done

Copy link
Collaborator

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you also thought about adding TotalBytesProcessed and TotalLinesProcessed from the response summary?

README.md Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@vlad-diachenko
Copy link
Contributor Author

TotalLinesProcessed fro

It depends on customer needs... bytesProcessedPerSecond and linesProcessedPerSecond show us the speed of the Loki. TotalBytesProcessed and TotalLinesProcessed show the only amount of data that is processed during the query.
If you think that these two fields are useful, we can add them.
What do you think?

@chaudum
Copy link
Collaborator

chaudum commented Feb 8, 2022

If you think that these two fields are useful, we can add them.

Yes, I think both metrics are useful.
Can be done in a separate PR.

@vlad-diachenko vlad-diachenko merged commit 88e7fc9 into main Feb 8, 2022
@vlad-diachenko vlad-diachenko deleted the added_response_stats_as_k6_metrics branch February 8, 2022 13:27
@vlad-diachenko
Copy link
Contributor Author

thanks @chaudum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants