Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows queries to take an offset #36

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Allows queries to take an offset #36

merged 6 commits into from
Jun 8, 2022

Conversation

dannykopping
Copy link
Contributor

No description provided.

@dannykopping dannykopping requested review from chaudum and mstoykov and removed request for chaudum May 5, 2022 09:00
Copy link
Collaborator

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, that is super useful! 👏

Could you also add the new functions to the reference documentation in the README?

Since the existing query functions are now "shortcuts" for the new "*At" functions, you can use a similar pattern as with the push() function, see

https://github.com/grafana/xk6-loki/blob/main/README.md?plain=1#L76-L94

Danny Kopping added 2 commits June 7, 2022 08:12
@dannykopping
Copy link
Contributor Author

Thanks for the addition, that is super useful! clap

Could you also add the new functions to the reference documentation in the README?

Since the existing query functions are now "shortcuts" for the new "*At" functions, you can use a similar pattern as with the push() function, see

https://github.com/grafana/xk6-loki/blob/main/README.md?plain=1#L76-L94

Apologies for the long delay @chaudum and @mstoykov! I've made these changes in 23b2096

Copy link
Collaborator

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

README.md Outdated
|----------|----------------|---------------------------------------|---------|
| query | string | The LogQL query to perform. | - |
| limit | integer | Maxiumum number of entries to return. | - |
| instant | 64-bit integer | Nanosecond at which to execute query. | - |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simply write integer as type, because there is only a Number type, which is a double-precision floating point (64 bit) number. (Well, there is also bigint ...)

Suggested change
| instant | 64-bit integer | Nanosecond at which to execute query. | - |
| instant | integer | Nanosecond at which to execute query. | - |

😏
2022-06-08_09-18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done 👍

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Copy link
Collaborator

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this addition!

@chaudum chaudum merged commit 12ab14d into main Jun 8, 2022
@chaudum chaudum deleted the query-offset branch June 8, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants