-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows queries to take an offset #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition, that is super useful! 👏
Could you also add the new functions to the reference documentation in the README?
Since the existing query functions are now "shortcuts" for the new "*At" functions, you can use a similar pattern as with the push()
function, see
https://github.com/grafana/xk6-loki/blob/main/README.md?plain=1#L76-L94
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Apologies for the long delay @chaudum and @mstoykov! I've made these changes in 23b2096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
README.md
Outdated
|----------|----------------|---------------------------------------|---------| | ||
| query | string | The LogQL query to perform. | - | | ||
| limit | integer | Maxiumum number of entries to return. | - | | ||
| instant | 64-bit integer | Nanosecond at which to execute query. | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simply write integer
as type, because there is only a Number type, which is a double-precision floating point (64 bit) number. (Well, there is also bigint ...)
| instant | 64-bit integer | Nanosecond at which to execute query. | - | | |
| instant | integer | Nanosecond at which to execute query. | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done 👍
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this addition!
No description provided.