Use easy json #43
Merged
Use easy json #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
approved these changes
Jul 7, 2022
|
@mstoykov Can you update the base branch of your PR and resolve the conflicts. Then I can merge it. |
NewBatch-8 114µs ± 6% 116µs ± 4% ~ (p=0.182 n=10+9) Encode/encode_protobuf-8 5.46µs ± 3% 5.86µs ± 3% +7.26% (p=0.000 n=10+10) Encode/encode_json-8 27.1µs ± 4% 25.1µs ± 5% -7.42% (p=0.000 n=9+10) name old alloc/op new alloc/op delta NewBatch-8 8.23kB ± 0% 8.21kB ± 0% -0.14% (p=0.045 n=10+10) Encode/encode_protobuf-8 2.54kB ± 0% 2.54kB ± 0% ~ (all equal) Encode/encode_json-8 5.36kB ± 0% 5.49kB ± 0% +2.39% (p=0.000 n=7+10) name old allocs/op new allocs/op delta NewBatch-8 184 ± 0% 184 ± 0% ~ (all equal) Encode/encode_protobuf-8 4.00 ± 0% 4.00 ± 0% ~ (all equal) Encode/encode_json-8 64.0 ± 0% 59.0 ± 0% -7.81% (p=0.000 n=10+10)
|
@chaudum done ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the stdlib one but it turned out it like 2x slower in this particular case :(.
K6 does use easyjson and we never have had a panic.
I did have a panic with the benchmarks with the original json-iterator version one out of 3 runs. Given the list of open panic reports I am not really certain it's good idea to use json-iterator ...
Their performance is in practice the same in this case (you can see benchmark results in the update commit message).