Update k6 and Loki dependencies #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
mstoykov
reviewed
Oct 10, 2022
| @@ -4,9 +4,11 @@ GO_FILES := $(shell find . -type f -name "*.go" -print) | |||
| .PHONY: run | |||
|
|
|||
| k6: $(GO_FILES) | |||
| xk6 build \ | |||
| xk6 build v0.40.0 \ | |||
There was a problem hiding this comment.
Suggested change
| xk6 build v0.40.0 \ | |
| xk6 build \ |
latest versions (from April at this point) of xk6 already build with w/e is in the actual go.mod(s) of the extensions - so you can just bump it in go.mod - which you already did ;)
There was a problem hiding this comment.
I guess I should update my xk6 binary then :D
Is it ok to still keep it for backwards compatibility?
mstoykov
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.