Record push metrics on successful push to Loki #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marc-sensenich
force-pushed
the
record-push-metrics-on-success
branch
from
3972406
to
28f64a5
Compare
chaudum
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Hey @marc-sensenich thanks for the fix. I suggested a small change, but overall LGTM!
Move the recording of metrics related to pushing a batch to Loki from the creation of the batch to after the successful push of a batch to have the metric better align with the description. Signed-off-by: Marc Sensenich <github@marc-sensenich.com>
marc-sensenich
force-pushed
the
record-push-metrics-on-success
branch
from
28f64a5
to
59e2271
Compare
|
@chaudum thank you for following up on the review, just wanted to give a ping since notifications can get missed in all of the others we get throughout the day |
chaudum
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the recording of metrics related to pushing a batch to Loki from the creation of the batch to after the successful push of a batch to have the metric better align with the description.
Signed-off-by: Marc Sensenich github@marc-sensenich.com