Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extension config and random data generation #59

Merged
merged 6 commits into from
Mar 15, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 15, 2023

Look at this commit by commit. The summary is:

  • I added support for an object-based config, so we can add additional configuration options without exploding the number of loki.Config() positional parameters
  • Removed the artificial restriction for creating a Config in the init context
  • Inlined a partial copy of the github.com/chaudum/flog dependency and refactored all pseudo-random data generation to be deterministic, controlled by the initial randSeed value in every Config.

⚠️ This PR also fixes a major bug where pushParameterized() didn't send the specified amount of data, it only sent 1/numStreams! See 243abf4

@na-- na-- marked this pull request as ready for review March 15, 2023 14:54
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- merged commit c5c764b into main Mar 15, 2023
@na-- na-- deleted the refactor-config-and-random-data branch March 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants