Report any 2xx reponse as successful request #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loki requests return with HTTP 204 (No Content) when pushing logs. Any 2xx status code indicates a successful HTTP response, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#successful_responses Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
mstoykov
approved these changes
Nov 30, 2021
|
I wonder if you shouldn't include 302(3xx in general) as k6 does by default for HTTP requests as I would expect somewhere in the future that you will test a loki behind an LB using redirects (for example) and then you will need a change again? |
Not sure if I'd expect a redirect, certainly not from a write request (even though 307 would allow POST redirects). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki requests return with HTTP 204 (No Content) when pushing logs.
Any 2xx status code indicates a successful HTTP response, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#successful_responses
Signed-off-by: Christian Haudum christian.haudum@gmail.com