Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output #1

Merged
merged 6 commits into from
Nov 8, 2021
Merged

Output #1

merged 6 commits into from
Nov 8, 2021

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Oct 18, 2021 •
edited

The InfluxDB v2 output implementation

TODO

  • Concurrent flush (Concurrent flush #2)
  • Dockerfile k6+xk6-influxdb
  • Summary why this is not part of the core like v1
  • Not use the admin token in compose Added a note comment about it
  • Update the header in code files

@codebien codebien self-assigned this Oct 18, 2021
@codebien codebien force-pushed the output branch 4 times, most recently from 0123be2 to 37fa3ad Compare October 28, 2021 15:46
@codebien codebien marked this pull request as ready for review November 3, 2021 15:35
mstoykov
mstoykov approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yorugac
yorugac requested changes Nov 5, 2021
View reviewed changes
Copy link

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, just one place in the explanations that I wouldn't have understood if I didn't have a previous idea on what it's about 😅 Perhaps, it could be rephrased a bit as it's one of the 1st things that will be read by anyone opening the repo?

README.md Outdated Show resolved Hide resolved
@codebien
Copy link
Collaborator Author

codebien commented Nov 5, 2021

@yorugac updated, added a title and a first period giving more context. WDYT?

yorugac
yorugac approved these changes Nov 5, 2021
View reviewed changes
Copy link

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it sounds much clearer now. LGTM 👍

@codebien codebien merged commit dfdb735 into main Nov 8, 2021
@codebien codebien deleted the output branch November 8, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@yorugac yorugac yorugac approved these changes

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebien @mstoykov @yorugac