Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty up the example dashboard, use docker compose v2 #22

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

toscott
Copy link
Contributor

@toscott toscott commented Mar 3, 2023

Maybe fixes - #8.. but could still be further improved of course.

What
Pretty up the example dashboard
use docker compose v2
Adjust example test

Why
Example dashboard needed some pizzaz
docker-compose (v1) is deprecated in favor of compose v2 plugin: https://docs.docker.com/compose/
30 second run gives a slightly nicer set of datapoints than 10 seconds

Screen Shot 2023-03-03 at 3 04 16 PM

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@toscott toscott force-pushed the example_dashboard_influxdb2 branch from 09964b2 to e8e98cd Compare March 3, 2023 21:13
@javaducky javaducky self-requested a review March 8, 2023 12:50
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @toscott, for your contribution! 💪

@javaducky javaducky merged commit 7dfbdd8 into grafana:main Mar 8, 2023
@toscott toscott deleted the example_dashboard_influxdb2 branch March 9, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants