Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to k6 0.43.1, upgrade other dependencies #23

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

toscott
Copy link
Contributor

@toscott toscott commented Mar 9, 2023

What
Upgrade to k6 0.43.1, upgraded other dependencies with

go get -u ./...

Why
Wanted to try out the new built in browser capabilities with k6 0.43.X

How I tested
Ran both standard and docker builds.
Used binary to run a headless browser test

Current docker container is not capable of running browser tests as it does not have a browser installed.

@codebien codebien self-requested a review March 9, 2023 14:36
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor issues which should solve build failure as well.

go.mod Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! 💪

@javaducky javaducky merged commit 28964a9 into grafana:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants