Update Docker environment and instructions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
requested changes
Jan 26, 2022
Dockerfile
Outdated
| --with github.com/grafana/xk6-output-influxdb=. | ||
| RUN apk --no-cache add git | ||
| RUN CGO_ENABLED=0 go install go.k6.io/xk6/cmd/xk6@latest | ||
| RUN CGO_ENABLED=0 xk6 build --with github.com/grafana/xk6-output-influxdb=. --output /tmp/k6 |
There was a problem hiding this comment.
Suggested change
| RUN CGO_ENABLED=0 xk6 build --with github.com/grafana/xk6-output-influxdb=. --output /tmp/k6 | |
| RUN CGO_ENABLED=0 xk6 build --with github.com/grafana/xk6-output-influxdb=. |
Why not use the default folder?
There was a problem hiding this comment.
@codebien -> Line 11 -> COPY --from=builder /tmp/k6 /usr/bin/k6
There was a problem hiding this comment.
it is the motivation why the Line 11 before was COPY --from=builder /go/bin/k6 /usr/bin/k6 for using the default Go binary folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it work and consistent with https://github.com/grafana/xk6-output-timescaledb/