Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on k6's json and InfluxDB outputs #1

Closed
mstoykov opened this issue Apr 1, 2021 · 2 comments · Fixed by #2
Closed

Remove dependency on k6's json and InfluxDB outputs #1

mstoykov opened this issue Apr 1, 2021 · 2 comments · Fixed by #2

Comments

@mstoykov
Copy link
Collaborator

mstoykov commented Apr 1, 2021

Both of the dependencies are so Kafka can format metrics in both of the formats.

While it's probably not great to copy-paste this code the alternative is that any changes to those might break this extension which especially as time goes by will not be an easy thing to avoid.

Even now the InfluxDB output will need to be refactored and moved from the old "collector" interface to the "Output" one, which will break this extension 😭.

Additionally, for InfluxDB we should probably copy 1-2 configurations such as tagsAsFields and precision.

We also intend on updating the influxdb library in k6 to support v2 which may or may not mean we will drop v1, but also means that the API will likely change and that

Given all of the above, I do think it's probably better to do this change now and drop any dependency on k6 that isn't the Output interface and its registration

@simskij
Copy link

simskij commented Apr 1, 2021

Isn't it better to just let it break in those cases, to make sure someone contributing here handles the breaking change as well?

@mstoykov
Copy link
Collaborator Author

mstoykov commented Apr 1, 2021

The problem @simskij is that I (or whoever works on the moving of the collector to output and then adding of infludbv2) am going to have to come back and fix this extension as well as we will be using it in k6 for at least 2-3 releases more so ... in reality this will save me doing a dance of fixes between the two repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants