Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependancies #2

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Drop dependancies #2

merged 3 commits into from
Apr 2, 2021

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Apr 1, 2021

fixes #1

@mstoykov mstoykov requested review from imiric and na-- April 1, 2021 14:26
@mstoykov
Copy link
Collaborator Author

mstoykov commented Apr 1, 2021

As expected this means code copied around and unfortunately the one actual configuration that is used by kafka is tagsAsFields and it has the most complex of parsing (of the influxdb options).

The code is mostly just copied and I dropped some abstractions along the way. I have many ... things I don't like about it, but testing this albeit not as hard and slow as I imagined takes a while and I prefer if I do less breaking changes :D

IMO somewhere in the future this extensions (when it is no longer used by k6) should get v2. Where the influxdb configuration is actually prefixed with K6_KAFKA_INFLUXDB instead of K6_INFLUXDB and ... maybe XK6_KAFKA as well ?!?

EIther way I like to point out that this is not meant to be the best of codes I just need this so I don't have to fix it on everytime we do something to those outputs in k6

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I didn't pay a ton of attention 😅

@mstoykov mstoykov merged commit d507d01 into master Apr 2, 2021
@mstoykov mstoykov deleted the dropDependancies branch April 2, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on k6's json and InfluxDB outputs
2 participants