Adjust mapping of the k6's metrics to the OTEL metrics #8

olegbespalov · 2024-06-06T09:56:15Z

What?

It's a minor refactoring of existing logic
I'm adding rate matric handling as proposed (Implement rate as counter #4 (comment)). I'm also going to open the ticket and try to gather feedback from the community.
Switching the gauge to the OTEL Gauge.
Minor (not final) dashboard adjustments

We'd like to export all metrics properly.

pkg/opentelemetry/output.go

mstoykov

LGTM! apart from the suggested change on the rate for consistency

Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>

olegbespalov requested review from mstoykov and codebien June 6, 2024 09:56

olegbespalov requested a review from a team as a code owner June 6, 2024 09:56

olegbespalov mentioned this pull request Jun 6, 2024

Implement rate as counter #4

Closed

codebien approved these changes Jun 6, 2024

View reviewed changes

mstoykov reviewed Jun 10, 2024

View reviewed changes

pkg/opentelemetry/output.go Outdated Show resolved Hide resolved

mstoykov approved these changes Jun 10, 2024

View reviewed changes

olegbespalov and others added 4 commits June 10, 2024 15:13

Refactor to metrics registry

563afbc

Implement Rate splitting

855e706

Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>

Adjust dashboard

b0470c3

A proper gauge

5a52d7e

olegbespalov force-pushed the feat/adjust-metric-proxying branch from 3220199 to 5a52d7e Compare June 10, 2024 13:13

olegbespalov merged commit d0f4424 into main Jun 10, 2024
10 checks passed

olegbespalov deleted the feat/adjust-metric-proxying branch June 10, 2024 13:27