Bump dependencies #120
Merged
Bump dependencies #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
approved these changes
May 15, 2023
|
@mstoykov Do you plan to update protobuf on k6 side? I think it could break the API here also and there isn't enough coverage on that front from the tests to make it safe. |
|
I see 1.29 introduced a breaking change https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.29.0 |
|
I dropped it, It would require dedicated tests. I opened an issue #121 for bumping all the prom-related deps at once. I will do it in the upcoming weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.