-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace dashboard, add new example #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One minor note. Would you mind updating the README.md
to correctly use samples/test.js
instead of example/test.js
. Looks like we missed this on the last PR which refactored the location of the scripts.
yes, im working on new readme, with new examples and test case, and grafana dashboard information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jwcastillo,
thanks for your contribution 🙏 This is awesome 🎉
I left some comments, in addition I think we should add a quick description about the various available dashboards here: https://github.com/grafana/xk6-output-prometheus-remote/blob/main/grafana/dashboards/README.md.
I'm not sure I'm getting how you are computing the testid
field, can you clarify, please?
@@ -21,12 +21,12 @@ | |||
} | |||
] | |||
}, | |||
"description": "List of k6 test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "List of k6 test", | |
"description": "List of k6 test runs", |
export default function () { | ||
http.get('https://test.k6.io/'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding a second example? Is test.js
not enough?
add new dashboard version