Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace dashboard, add new example #46

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

jwcastillo
Copy link
Contributor

add new dashboard version
image
image

@codebien codebien self-requested a review October 3, 2022 07:43
@javaducky javaducky assigned javaducky and unassigned javaducky Oct 12, 2022
@javaducky javaducky self-requested a review October 12, 2022 14:25
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One minor note. Would you mind updating the README.md to correctly use samples/test.js instead of example/test.js. Looks like we missed this on the last PR which refactored the location of the scripts.

@jwcastillo
Copy link
Contributor Author

LGTM!

One minor note. Would you mind updating the README.md to correctly use samples/test.js instead of example/test.js. Looks like we missed this on the last PR which refactored the location of the scripts.

yes, im working on new readme, with new examples and test case, and grafana dashboard information

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jwcastillo,
thanks for your contribution 🙏 This is awesome 🎉

I left some comments, in addition I think we should add a quick description about the various available dashboards here: https://github.com/grafana/xk6-output-prometheus-remote/blob/main/grafana/dashboards/README.md.

I'm not sure I'm getting how you are computing the testid field, can you clarify, please?

@@ -21,12 +21,12 @@
}
]
},
"description": "List of k6 test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "List of k6 test",
"description": "List of k6 test runs",

Comment on lines +11 to +13
export default function () {
http.get('https://test.k6.io/');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding a second example? Is test.js not enough?

@javaducky javaducky merged commit 0cf39ad into grafana:main Nov 28, 2022
javaducky added a commit that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants