Removed the prometheus/prometheus go library #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
LGTM 👏
I haven't tested it locally to see if it works, or there are any particular problems, but am also not accustomed with prometheus enough to find them 🤷
I have left a bunch of comments that are about renames and/or opening issues, but non of them are blocking the merge IMO
olegbespalov
approved these changes
Nov 2, 2022
olegbespalov
reviewed
Nov 2, 2022
codebien
force-pushed
the
promclient
branch
2 times, most recently
from
2a0a0ca
to
c5a111a
Compare
olegbespalov
approved these changes
Nov 9, 2022
mstoykov
approved these changes
Nov 9, 2022
It has been replaced with a lighter version based on buf.build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been replaced with a lighter version based on buf.build.
Closes #41