TrendSink from k6 and sorted labels #58

codebien · 2022-11-18T15:37:36Z

Refactoring that contains the following updates:

Now, it uses directly the TrendSink defined from the metrics pkg of k6. The recent refactor on k6 has enabled this step. It has required bumping the k6 version to the master branch.
The generated labels are now sorted in a lexicographic order as required by the Remote write specification.

k6 master branch includes an optimization of TrendSink that is useful for the extension.

pkg/remotewrite/prometheus.go

olegbespalov

👍

pkg/remotewrite/trend.go

codebien added 3 commits November 17, 2022 17:46

Migrated to k6.metrics.TrendSink

2a2aa38

Bump k6 version to master

bee1378

k6 master branch includes an optimization of TrendSink that is useful for the extension.

Sort labels with lexicographic order

f57c564

codebien self-assigned this Nov 18, 2022

codebien requested a review from olegbespalov November 18, 2022 15:37

olegbespalov reviewed Nov 21, 2022

View reviewed changes

pkg/remotewrite/prometheus.go Outdated Show resolved Hide resolved

olegbespalov reviewed Nov 21, 2022

View reviewed changes

pkg/remotewrite/prometheus.go Outdated Show resolved Hide resolved

Moved Prompb mapping to the TrendSink

118a7a2

codebien force-pushed the k6-metric-trend branch from 3a2b90b to 118a7a2 Compare November 22, 2022 10:37

codebien requested a review from olegbespalov November 22, 2022 11:02

olegbespalov approved these changes Nov 22, 2022

View reviewed changes

olegbespalov reviewed Nov 22, 2022

View reviewed changes

pkg/remotewrite/trend.go Outdated Show resolved Hide resolved

Renamed to CacheNameIndex

397276c

codebien force-pushed the k6-metric-trend branch from fc2b071 to 397276c Compare November 22, 2022 12:06

codebien merged commit b72ddfb into main Nov 22, 2022

codebien deleted the k6-metric-trend branch November 22, 2022 13:45

Provide feedback