Relax response status code policy #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remote-write specification doesn't define the expected status code. It extends the policy to all the successful status codes because it can't make assumptions. There are so many implementations and the protocol doesn't limit them to return any code. e.g. Mimir uses a 200 OK as response status code.
codebien
force-pushed
the
fix-mimir-status-code
branch
from
50bfef3
to
52e054f
Compare
olegbespalov
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote-write specification doesn't define the expected status code. It extends the policy to all the successful status codes because it can't make assumptions. There are so many implementations and the protocol doesn't limit them to return any code.
e.g. Mimir uses a 200 OK as a response status code.