Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop options from cli argument #70

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Drop options from cli argument #70

merged 1 commit into from
Dec 1, 2022

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Nov 29, 2022

k6 doesn't have a defined way of providing Output options. Instead of adding one more way, we should define one standard for all of them and only after adopting it here.

@codebien codebien self-assigned this Nov 29, 2022
@codebien codebien mentioned this pull request Nov 29, 2022
@javaducky
Copy link
Contributor

Agreed...we need to come up with a good option or simply utilize env vars. I dislike how we have URLs tagging along on the output type for TimescaleDB (e.g. -o timescaledb=postgresql://k6:k6@timescaledb:5432/k6) and InfluxDB (e.g. -o xk6-influxdb=http://localhost:8086) as well...reminds me too much of JDBC connection strings. 🤷

@codebien codebien merged commit bcf82f6 into main Dec 1, 2022
@codebien codebien deleted the drop-cli-config branch December 1, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants