Force the naming convention #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For counter type the convention is to use _total suffix https://prometheus.io/docs/practices/naming/#metric-names Added _rate suffix for Rate type that doesn't have a 1:1 mapping in Prometheus.
oleiade
approved these changes
Dec 1, 2022
olegbespalov
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prometheus.io/docs/practices/naming/#metric-names
_totalsuffix for the Counter type as suggested by the Prometheus and OpenMetrics conventions._ratesuffix for the Rate type so it can be identified easier because they are converted into Gauges.