fix: update dashboards to new naming convention #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
reviewed
Dec 6, 2022
| @@ -3450,7 +3450,7 @@ | |||
| }, | |||
| "editorMode": "code", | |||
| "exemplar": false, | |||
| "expr": "avg(k6_my_rate{testid=~\"$testid\"})", | |||
| "expr": "avg(k6_my_rate_rate{testid=~\"$testid\"})", | |||
| @@ -3294,7 +3294,7 @@ | |||
| "type": "prometheus", | |||
| "uid": "PEDF09670F151C95C" | |||
| }, | |||
| "expr": "k6_my_counter{testid=~\"$testid\"}", | |||
| "expr": "k6_my_counter_total{testid=~\"$testid\"}", | |||
There was a problem hiding this comment.
Do we need this custom metric in the dashboard?
There was a problem hiding this comment.
It depends on what the objective of this dashboard is, if it is to show test results it may not be necessary, but if it is an example for others to build their own dashboard it could make the job easy.
I have no problem removing it.
There was a problem hiding this comment.
@ppcano @javaducky can you share your thoughts here, please?
Let's merge for now. We will fix it in the next few days if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard update to the new naming convention