Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale marker option #86

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Stale marker option #86

merged 2 commits into from
Dec 15, 2022

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Dec 15, 2022

It introduces a new option K6_PROMETHEUS_RW_STALE_MARKERS=<bool> for enabling the Staleness marking process at the end of the test. It also disables the option by default.

@codebien codebien self-assigned this Dec 15, 2022
@codebien codebien marked this pull request as ready for review December 15, 2022 12:27
@codebien codebien requested a review from imiric December 15, 2022 12:27
@codebien codebien mentioned this pull request Dec 15, 2022
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I haven't investigated the Prometheus details here, just done a review of the code in the PR as it is.

Copy link

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for splitting apart the PRs 🤗

pkg/remote/client_test.go Outdated Show resolved Hide resolved
@codebien codebien merged commit 43e6aab into main Dec 15, 2022
@codebien codebien deleted the stale-marker-option branch December 15, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants