Update dashboard #94
Closed
Update dashboard #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
requested changes
Jan 9, 2023
There was a problem hiding this comment.
Hey @jwcastillo,
it seems the branch has some conflicts. Can you rebase, please?
codebien
reviewed
Jan 13, 2023
There was a problem hiding this comment.
Hey @jwcastillo,
the file with conflicts is grafana/dashboards/dashboard-results.json
You can pull the main branch's changes locally then move to your branch and try to rebase it, you should get the conflict and the specific lines.
* Import k6's golangci-lint configuration * Address linting issues repository-wide
There are no reasons to set it to true, the default server URL is HTTP based and if an HTTPS endpoint is added then the client validation is expected to happen with the default path.
Sample: add new sample * Use instant query for counters
Labels with empty key or value are not allowed by the remote write spec, so if any seen tag contains them then they are not mapped to the related label.
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
…ometheus-remote into apdex_dashboard
|
Hey @jwcastillo, If you can't recover then I suggest starting over in a clean branch where the parent is the |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Dashboard closing 2022
It includes:
All available k6 metrics - prometheus
Apdex
Does not include:
Custom Metrics