Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and go.mod to match k6 #20

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

javaducky
Copy link
Contributor

@javaducky javaducky commented Jan 25, 2023

Encountered dependency issues when building docker image with xk6. Bumping builder image and base image to match that of k6 itself, as well as bumping the dependency modules to same 1.17 compatibility level.

Fixes #19

Fixes #19

Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Signed-off-by: Paul Balogh <javaducky@gmail.com>
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe bump the go.mod version further if we expect net/netip?

Signed-off-by: Paul Balogh <javaducky@gmail.com>
@javaducky javaducky merged commit 474abdf into main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build is broken
2 participants