-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the URL of the Oracle fork in README #32
Conversation
Because of a username change, the fork with the Oracle adapter needed to be re-linked
@imiric I needed to update the readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks!
Could you also update the import URL in the extension repo, and the below xk6 build
command? Currently the command works fine because of GitHub redirects, but it fails building --with github.com/stefnedelchevbrady/xk6-sql-with-oracle
because of the path difference. So we should make this consistent.
@imiric thanks for noticing, I just updated all URLs in the readme and go.mod of my fork stefnedelchevbrady@0d9460e stefnedelchevbrady@45975ca |
Thanks! I actually meant the |
@imiric sorry I seem to have missed those lines 😆 . I updated them in a new commit stefnedelchevbrady@f35b5f8 |
You need to make the commit on your |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now!
Because of a username change, the fork with the Oracle adapter needed to be re-linked