Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the URL of the Oracle fork in README #32

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

stefnedelchevbrady
Copy link
Contributor

Because of a username change, the fork with the Oracle adapter needed to be re-linked

Because of a username change, the fork with the Oracle adapter needed to be re-linked
@stefnedelchevbrady
Copy link
Contributor Author

@imiric I needed to update the readme

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks!

Could you also update the import URL in the extension repo, and the below xk6 build command? Currently the command works fine because of GitHub redirects, but it fails building --with github.com/stefnedelchevbrady/xk6-sql-with-oracle because of the path difference. So we should make this consistent.

@stefnedelchevbrady
Copy link
Contributor Author

stefnedelchevbrady commented Feb 13, 2023

Hey, thanks!

Could you also update the import URL in the extension repo, and the below xk6 build command? Currently the command works fine because of GitHub redirects, but it fails building --with github.com/stefnedelchevbrady/xk6-sql-with-oracle because of the path difference. So we should make this consistent.

@imiric thanks for noticing, I just updated all URLs in the readme and go.mod of my fork stefnedelchevbrady@0d9460e stefnedelchevbrady@45975ca

@imiric
Copy link
Contributor

imiric commented Feb 13, 2023

Thanks! I actually meant the xk6 build command on line 134 of this repo's README 😄

@stefnedelchevbrady
Copy link
Contributor Author

stefnedelchevbrady commented Feb 13, 2023

@imiric sorry I seem to have missed those lines 😆 . I updated them in a new commit stefnedelchevbrady@f35b5f8

@imiric
Copy link
Contributor

imiric commented Feb 13, 2023

You need to make the commit on your patch-1 branch, so that we can merge it here...

@stefnedelchevbrady
Copy link
Contributor Author

You need to make the commit on your patch-1 branch, so that we can merge it here...

done

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now!

@imiric imiric merged commit 39494e4 into grafana:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants