[2/3] Implement the exportKey and importKey operations with support for AES algorithms
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
changed the title
exportKey and importKey operations with support for AES algorithms
This was referenced Mar 27, 2023
|
Comment on the PR description: Can we update the README in all of those PRs and
|
imiric
suggested changes
Mar 27, 2023
oleiade
force-pushed
the
feature/generateKey-symmetric
branch
4 times, most recently
from
68abb91
to
a2cd5eb
Compare
oleiade
force-pushed
the
feature/importKey-exportKey-symmetric
branch
4 times, most recently
from
d5d54c8
to
9060976
Compare
oleiade
force-pushed
the
feature/generateKey-symmetric
branch
from
a2cd5eb
to
34fa553
Compare
oleiade
force-pushed
the
feature/importKey-exportKey-symmetric
branch
from
9060976
to
b30f6cc
Compare
oleiade
force-pushed
the
feature/generateKey-symmetric
branch
from
575c685
to
86e837f
Compare
oleiade
force-pushed
the
feature/importKey-exportKey-symmetric
branch
from
9de2272
to
a2a2a71
Compare
mstoykov
approved these changes
Mar 28, 2023
This commit imports and adapts the WebCrypto test suite to work within the k6 context. We also commented out algorithms that are not yet implemented.
oleiade
force-pushed
the
feature/importKey-exportKey-symmetric
branch
from
a2a2a71
to
f5585b0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this is
This PR implements to support the
importKeyandexportKeyoperations. To keep Pull Requests as small and manageable as possible, It only implements support for the AES family of algorithms.main✋🏻The
exportKeyoperation allows exporting an existingCryptoKeyobject into its raw format representation (note that this PR does not support the JWK format) as anArrayBuffer, for being either written down to storage or reimported in a different context.The
importKeyoperation does the opposite. It allows importing of a key in its raw (note that here too, this PR does not support the JWK format) representation format (anArrayBuffer) as aCryptoKeyobject.🟢 While the PR shows +400 changes, roughly half of them are from the official test suites, which do not need to be reviewed 🟢
Review
Test suite
While the PR might look big at first glance, you can safely disregard and ignore the files in the
webcrypto/testsfolder. Those files are directly imported and slightly adapted from the official test suite so that they are runnable in k6, but we haven't written those originally. We won't make any functional changes to them, as they are our safety net, ensuring that our implementation matches the specifications expectation (and that what we do is 🥁 safe).References
This PR is the second chain of 3 implementing support for key generation (1.), import/export (2.), and encryption/decryption using them. We intend to merge these in order in master: 1->2->3.