[2/3] Implement the exportKey and importKey operations with support for HMAC algorithm
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
feature/generateKey-hmac
branch
from
4f79696
to
0360eb2
Compare
oleiade
force-pushed
the
feature/importKey-exportKey-hmac
branch
from
66d876d
to
295b13e
Compare
mstoykov
reviewed
Mar 31, 2023
oleiade
force-pushed
the
feature/importKey-exportKey-hmac
branch
from
941b1e8
to
d2fab94
Compare
oleiade
force-pushed
the
feature/importKey-exportKey-hmac
branch
from
d2fab94
to
3649773
Compare
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
oleiade
force-pushed
the
feature/importKey-exportKey-hmac
branch
from
3649773
to
68f9533
Compare
mstoykov
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This Pull Request adds support for the HMAC algorithm to the
subtle.crypto.importKeyandsubtle.crypto.exportKeyoperations. It is the second PR of a chain of three PRs converging towards introducing thesignandverifyAPIs to the extension.Our plan moving forward is to go breadth first, and implement as much of the WebCrypto API's surface, and only later to add support for more algorithms. As a result this PR comes in with the intention to support the ability to implement the
signandverifyoperations to the module.Just like with
encryptanddecrypt, the sign and verify operations test suite rely on the ability to import and export a key of a support algorithm. As a result to support sign and verify with a scope reduced to the HMAC algorithm, we need to implementimportKeyandexportKeyfirst.Review
Note that like in the
generateKeyPR we introduce a new interface for key import:KeyImporter. Although we could have extended this principle to key export, we decided to delay that until we support key pairs, as we lack visibility to decide whether or not this will remain a good abstraction in the future.This PR is based on the HMAC support for the
generateKeyPR, and will act as the base for a third PR to come which will introduce thesignandverifymethods to the extension.