Align how digest copies bytes with the rest of the methods #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
refactor/ensure-bytes-are-copied
branch
from
cc7e87e
to
bb7862f
Compare
oleiade
force-pushed
the
refactor/ensure-bytes-are-copied
branch
from
bb7862f
to
d6bcbae
Compare
codebien
approved these changes
Apr 14, 2023
imiric
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For methods taking
ArrayBuffer,TypedArrayorDataViewas input, the specification often states that the underlying bytes should be copied. This is made so that modifying the data that's passed as argument in an asynchronous manner doesn't result in inconsistencies of the cryptographic operation.This PR closes #42 and ensures that the
digestmethod uses our internalexportArrayBufferfunction which makes sure to return a copy of the underlying's buffer bytes.