Refactor bits/bytes conversion #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
refactor/bits-bytes-conversion
branch
2 times, most recently
from
3b4282e
to
2b3ed69
Compare
imiric
approved these changes
Apr 14, 2023
oleiade
force-pushed
the
refactor/bits-bytes-conversion
branch
from
2b3ed69
to
4c72387
Compare
mstoykov
reviewed
Apr 19, 2023
oleiade
force-pushed
the
refactor/bits-bytes-conversion
branch
from
4c72387
to
fc4f3d6
Compare
mstoykov
reviewed
Apr 19, 2023
mstoykov
approved these changes
Apr 21, 2023
| @@ -86,7 +86,7 @@ func (akgp *AESKeyGenParams) GenerateKey( | |||
| key.Type = SecretCryptoKeyType | |||
| key.Algorithm = AESKeyAlgorithm{ | |||
| Algorithm: akgp.Algorithm, | |||
| Length: akgp.Length, | |||
| Length: int64(akgp.Length), | |||
There was a problem hiding this comment.
Can we change that Length field as well?
There was a problem hiding this comment.
To the best of my knowledge, unfortunately not. The reason is that as soon as you use bitLength as a type for the Length attribute the AesKeyAlgorithm type, then its value is treated as an object by Goja, not a number, which leads the test suite to fail. I have noticed this behavior before, hence some of the type mappings that exist are actual type aliases type mytype = string. However, in that case, we can't really do that, as we wouldn't be able to have methods on type aliases.
oleiade
force-pushed
the
refactor/bits-bytes-conversion
branch
from
fc4f3d6
to
b96901b
Compare
mstoykov
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #36 and introduces two new type aliases:
bitLengthandbyteLengthhelping make conversion from bytes length to bits and vice versa, more explicit, readable, and less error prone.closes #36