Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate more autobahn failures and improvement to the test #4

Open
mstoykov opened this issue Jul 11, 2022 · 3 comments
Open

Investigate more autobahn failures and improvement to the test #4

mstoykov opened this issue Jul 11, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mstoykov
Copy link
Collaborator

There are still some test (from the very late ones) that are failing. Unfortunately it isn't immediately obvious what they test or what is failing exactly so that will likely take quite a lot of work on it's own :(.

It might also be due to the websocket library we are using which is still looking for maintainers and isn't all that up to date.

We likely will want to at least try other variants in the future as well.

@imiric
Copy link

imiric commented Nov 14, 2022

Hey @mstoykov, I'm not clear on what needs to be done here.

I see that gorilla/websocket mentions Autobahn tests in their README, but I'm confused why we need to run the suite, since we're not implementing the WS protocol ourselves, and both k6/ws and k6/experimental/websockets use gorilla/websocket.

So why (and how) should we run this? And what can/should we do in case of any failures?

@mstoykov
Copy link
Collaborator Author

The autobahn test was added by @codebien in #1 and can be run as explained in the README.

It already helped with some fixes as shown in https://github.com/grafana/xk6-websockets/pull/3/files.

I have no idea though what the current failures are due to (you will need to run them) as I find the documentation around it to be abysmal. It is likely they are to do with less relevant features or expectations, given that much later tests fail.

@mstoykov
Copy link
Collaborator Author

mstoykov commented Apr 5, 2023

It turns out that the reports folder under the autobahn do get populated with a really nice html report that can be looked at in a browser which has a ton of information 🎉.

Obviously I didn't notice this the previous time I looked at it 🤦

@olegbespalov olegbespalov self-assigned this Jun 7, 2023
@olegbespalov olegbespalov added the enhancement New feature or request label Jun 13, 2023
@olegbespalov olegbespalov removed their assignment Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants