Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert extension to use atlas-based metric tags #12

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Convert extension to use atlas-based metric tags #12

merged 4 commits into from
Oct 4, 2022

Conversation

na--
Copy link
Member

@na-- na-- commented Aug 17, 2022 •
edited by codebien

Related to the changes introduced in grafana/k6#2594

@codebien codebien requested a review from mstoykov October 4, 2022 10:47
@codebien codebien marked this pull request as ready for review October 4, 2022 10:47
@codebien codebien changed the title [WIP] Convert extension to use atlas-based metric tags Convert extension to use atlas-based metric tags Oct 4, 2022
na--
na-- commented Oct 4, 2022
View reviewed changes
Copy link
Member Author

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@na-- na-- merged commit 2565a84 into main Oct 4, 2022
@na-- na-- deleted the atlas branch October 4, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@na-- @mstoykov @codebien