Implement WebSocket's onMessage, onError, onOpen, onClose #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
reviewed
Nov 16, 2022
Comment on lines
+150
to
+157
| must(rt, w.obj.DefineDataProperty( | ||
| "onMessage", rt.ToValue(w.generateEventListener(MESSAGE)), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE)) | ||
| must(rt, w.obj.DefineDataProperty( | ||
| "onError", rt.ToValue(w.generateEventListener(ERROR)), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE)) | ||
| must(rt, w.obj.DefineDataProperty( | ||
| "onOpen", rt.ToValue(w.generateEventListener(OPEN)), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE)) | ||
| must(rt, w.obj.DefineDataProperty( | ||
| "onClose", rt.ToValue(w.generateEventListener(CLOSE)), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE)) |
There was a problem hiding this comment.
This isn't really immediately obvious from the specification but one of the main differences between onerror and AddEventLisetner with error is that the second can add multiple while the first one can only add one eventHandler. If you set it a second time it overwrites it.
I can't find the exact place where it was also talked on which one was fired first, but we likely can not use the addEventListener underlying mechanics and instead will have to add a field to the WebSocket struct per each of those.
There was a problem hiding this comment.
Okay, now I see that. Thanks! 👍
|
The code will be absolutely different 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implementing the WebSocket's
on*Build on top of the #22
Why?
Resolves #11