Implement WebSocket customisation with headers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement paramitarisation of the WebSocket with headers param. This
allow users to pass any additional headers with the WebSocket
constructor.
An example: `var ws = new WebSocket("wss://host", [],
{headers: {"x-lorem": "ipsum"}})`
mstoykov
approved these changes
Nov 22, 2022
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
olegbespalov
force-pushed
the
feat/custom-headers
branch
from
7c59ddf
to
106614e
Compare
olegbespalov
force-pushed
the
feat/custom-headers
branch
from
af45945
to
64f5929
Compare
mstoykov
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implement parameterization of the WebSocket with headers param. This allows users to pass any additional headers with the WebSocket constructor.
An example:
var ws = new WebSocket("wss://host", [], {headers: {"x-lorem": "ipsum"}})Why?
Resolves #16