Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compession support #27

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Compession support #27

merged 1 commit into from
Nov 24, 2022

Conversation

olegbespalov
Copy link
Contributor

What?

Copying the compression support from the k6.

Why?

Resolves: #7

@olegbespalov olegbespalov changed the base branch from main to feat/cookies-jar November 23, 2022 08:45
Base automatically changed from feat/cookies-jar to main November 23, 2022 08:54
mstoykov
mstoykov reviewed Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test where the server does not support compression but we ask for it?

Just to know if that leads to an error or not

websockets/params.go Outdated Show resolved Hide resolved
mstoykov
mstoykov approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but I have a bunch of nitpicks, most of which can be handled later as well.

websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
websockets/websockets_test.go Outdated Show resolved Hide resolved
@olegbespalov olegbespalov merged commit 449f9b2 into main Nov 24, 2022
@olegbespalov olegbespalov deleted the feat/compression branch November 24, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support compression
2 participants
@olegbespalov @mstoykov