Implementation of the Ping/Pong #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from the k6/ws
mstoykov
reviewed
Nov 30, 2022
websockets/websockets.go
Outdated
|
|
||
| data := []byte(pingID) | ||
|
|
||
| err := w.conn.WriteControl(websocket.PingMessage, data, deadline) |
There was a problem hiding this comment.
In the previous( k6/ws) implementation all the methods did what they did (send/ping ) on the event loop more or less. This is not the case here send does not actually send the message anymore it queues it to be send. Given that ping also writes I feel like it should be off the main loop the same way the send is
There was a problem hiding this comment.
Tried to address in e1b5a46
mstoykov
approved these changes
Nov 30, 2022
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
mstoykov
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Porting ping/pong from the k6
Why?
Resolves: #6