go 1.16 compatibitity

[pmalhaire]

TLDR

using go 1.16 :

2021/03/01 18:02:48 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/pierrot/Downloads/k6 -ldflags -w -s -trimpath 
go: k6: package github.com/loadimpact/k6/cmd imported from implicitly required module; to add missing requirements, run:
	go get github.com/loadimpact/k6/cmd@v0.30.1-0.20210208205855-a379c3787372

workarround (Working fine)

Artificially add the k6 repo as golang 1.16 does not implicitly adds it to go mod.

./xk6 build  --with github.com/pmalhaire/xk6-mqtt --with github.com/loadimpact/k6/cmd

details

I may have done something wrong but compiling my extension does not seam to work using golang 1.16

with go 1.16

go version go1.16 linux/amd64

xk6 build  --with github.com/pmalhaire/xk6-mqtt 
2021/03/01 18:02:47 [INFO] Temporary folder: /tmp/buildenv_2021-03-01-1802.161811804
2021/03/01 18:02:47 [INFO] Writing main module: /tmp/buildenv_2021-03-01-1802.161811804/main.go
2021/03/01 18:02:47 [INFO] Initializing Go module
2021/03/01 18:02:47 [INFO] exec (timeout=10s): /usr/local/go/bin/go mod init k6 
go: creating new go.mod: module k6
go: to add module requirements and sums:
	go mod tidy
2021/03/01 18:02:47 [INFO] Pinning versions
2021/03/01 18:02:47 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/loadimpact/k6 
go get: added github.com/loadimpact/k6 v0.30.0
2021/03/01 18:02:48 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/pmalhaire/xk6-mqtt 
go get: upgraded github.com/loadimpact/k6 v0.30.0 => v0.30.1-0.20210208205855-a379c3787372
go get: added github.com/pmalhaire/xk6-mqtt v0.0.0-20210301160808-4ee3400d52b1
2021/03/01 18:02:48 [INFO] Build environment ready
2021/03/01 18:02:48 [INFO] Building k6
2021/03/01 18:02:48 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/pierrot/Downloads/k6 -ldflags -w -s -trimpath 
go: k6: package github.com/loadimpact/k6/cmd imported from implicitly required module; to add missing requirements, run:
	go get github.com/loadimpact/k6/cmd@v0.30.1-0.20210208205855-a379c3787372
2021/03/01 18:02:48 [INFO] Cleaning up temporary folder: /tmp/buildenv_2021-03-01-1802.161811804
2021/03/01 18:02:48 [FATAL] exit status 1

with go 1.15 all fine

xk6 build  --with github.com/pmalhaire/xk6-mqtt 
2021/03/01 17:59:40 [INFO] Temporary folder: /tmp/buildenv_2021-03-01-1759.483292408
2021/03/01 17:59:40 [INFO] Writing main module: /tmp/buildenv_2021-03-01-1759.483292408/main.go
2021/03/01 17:59:40 [INFO] Initializing Go module
2021/03/01 17:59:40 [INFO] exec (timeout=10s): /usr/local/go/bin/go mod init k6 
go: creating new go.mod: module k6
2021/03/01 17:59:40 [INFO] Pinning versions
2021/03/01 17:59:40 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/loadimpact/k6 
go: github.com/loadimpact/k6 upgrade => v0.30.0
2021/03/01 17:59:40 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/pmalhaire/xk6-mqtt 
go: github.com/pmalhaire/xk6-mqtt upgrade => v0.0.0-20210301160808-4ee3400d52b1
2021/03/01 17:59:41 [INFO] Build environment ready
2021/03/01 17:59:41 [INFO] Building k6
2021/03/01 17:59:41 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/pierrot/stereolabs/xk6-mqtt/k6 -ldflags -w -s -trimpath 
2021/03/01 17:59:50 [INFO] Build complete: ./k6
2021/03/01 17:59:50 [INFO] Cleaning up temporary folder: /tmp/buildenv_2021-03-01-1759.483292408

[na--]

Thanks for notifying us of this! I've added some xk6 compatibility tests in the xk6 repo with grafana/k6#1885, so when we fix this, we should add checks for Go 1.16 there and bump the used versions when new Go versions are released.

[pmalhaire]

Good TDD way !

The workarround I wrote works fine, so it's not blocking.

[kuchaguangjie]

Seems the general solution is go mod tidy, before start program.