Fixes around go get and cleaning up

[mstoykov]

go get seems to actually try to set and get the exact version you provide and so if it can't that is an error.

On the other hand go mod edit -require mostly adds it to the requirements and then the module resolution algorithm just removes it as there is actually a higher version already required effectively doing what we want.

[mstoykov]

This fixes grafana/xk6-output-kafka#7 (comment)

[imiric]

The cleanup change LGTM, but I'm not clear on why the go get change is needed. Can you explain it here and in the commit itself?

[na--]

LGTM, though yeah, some explanations in the PR description will be great. Also, I can't find it in the docs, but does go mod edit -require need Go 1.16 or would it also work on 1.15?

[mstoykov]

I don't really know why go get gets us the error but go mod doesn't ... maybe it's a bug maybe it's by design, but the one works and arguably is the thing that should be used either way.

go mod edit -require need Go 1.16 or would it also work on 1.15

I think it works ... for even lower versions but that is irrelevant as we use go:embed now and it's supported since go1.16 ;)

[imiric]

Strange... Yeah, seems like a bug related to the dependency changes we did when moving out the Kafka output, but I couldn't find anything on the issue tracker about it.

I confirmed the fix locally, so hopefully it won't break anything else 😅🤞

[mstoykov]

From some chatting in the #modules channel, it seems like go get does actually try to set and get the exact version you provide and so if it can't that is an error. On the other hand go mod edit -require mostly adds it to the requirements and then the module resolution algorithm just removes it as there is actually a higher version already required effectively doing what we want.