Add --replace argument
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/add-replace-arg
branch
from
8a99dde
to
d45ef64
Compare
`--replace` can be used multiple times to add replacements by specifying the Go module name and the replacement module, similar to `go mod edit -replace=`. Version of the replacement can be specified with the `@version` suffix in the replacement path. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/add-replace-arg
branch
from
d45ef64
to
14e662c
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
imiric
approved these changes
Nov 15, 2021
Comment on lines
+138
to
+143
| if got == "." { | ||
| t.Errorf("did not expand path") | ||
| } | ||
| if err != nil { | ||
| t.Errorf("failed to expand path") | ||
| } |
There was a problem hiding this comment.
Ah, we're not using stretchr/testify in the project yet 😞 Otherwise this would be simpler using require.NoError() and assert.NotEqual().
It's fine leaving it as is. We can change this everywhere once we add testify as a dependency.
mstoykov
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
LGTM, thanks for the PR 🙇
I kind of feel it will be nice if when we clean inputs (for example removing /) we actually tell users that this was done, just in case our assumptions about it not being valid come out to be false. But I also think in this case it's probably fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--replacecan be used multiple times to add replacements by specifyingthe Go module name and the replacement module, similar to
go mod edit -replace=. Version of the replacement can be specified with the@versionsuffix in the replacement path.Fixes #32
Signed-off-by: Christian Haudum christian.haudum@gmail.com