Refresh the README examples #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also fix the code example down the readme |
oleiade
force-pushed
the
refresh-readme
branch
2 times, most recently
from
23df488
to
9363fff
Compare
|
@mstoykov good catch! Done 👍🏻 |
mstoykov
reviewed
Nov 23, 2021
mstoykov
reviewed
Nov 23, 2021
The README examples kept referencing `github.com/k6io/xk6-sql` as the extension to build against. However, this repository does not exist anymore, and made the README inaccurate. To address it, this commit makes the examples point to `github.com/grafana/xk6-browser` instead.
oleiade
force-pushed
the
refresh-readme
branch
from
9363fff
to
8a05c67
Compare
mstoykov
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the information in the README's examples section. Those referred to a non-existing repository, they now point to
github.com/grafana/xk6-browser. I also added a mention of our documentation's extensions page, which might help users discover them if they haven't yet.