Forcing compat 1.17 version for gomod #35
Conversation
|
Why is that command required two times? It seems the builder already uses the environment 🤔 |
| @@ -94,7 +94,7 @@ func (b Builder) Build(ctx context.Context, outputFile string) error { | |||
| log.Println("[INFO] Building k6") | |||
|
|
|||
| // tidy the module to ensure go.mod and go.sum are consistent with the module prereq | |||
| tidyCmd := buildEnv.newCommand("go", "mod", "tidy") | |||
| tidyCmd := buildEnv.newCommand("go", "mod", "tidy", "-compat=1.17") | |||
There was a problem hiding this comment.
Wouldn't this force 1.17 as the minimum supported version for building? Do we want to impose that requirement? 🤔
|
My problems with this fix are:
Given that the list of broken extensions is now a single digit AFAIK, I am for just making PRs to fix those :) This isn't a veto of this PR just my opinion that the good it does is minimal and likely will give us more problems in the long run :( |
I didn't see the available option for the fix. According to this, it's for sure better. I'm closing, we can re-open if we will find different cases. |
It forces the builder to use the
go mod tidy -compat=1.17version in the case of conflict resolution.Should we add a way for the user of declaring to use the 1.16 version?