Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extensions files one by one so go mod tidy will always work #40

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

mstoykov
Copy link
Contributor

No description provided.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works fine from my tests as well 🤞

Couple things:

@mstoykov mstoykov merged commit 3431936 into master Feb 18, 2022
@mstoykov mstoykov deleted the addExtensionsOneByOne branch February 18, 2022 10:40
@mstoykov
Copy link
Contributor Author

I though I fixed the gosec ... but I fixed it in the other place 🤦

Yeah some testing will be nice to have, although I do have some hopes that we will not be touching this tool all that much at somepoint 🤞

@imiric
Copy link
Contributor

imiric commented Feb 18, 2022

I do have some hopes that we will not be touching this tool all that much at somepoint

Yeah, big 🤞, but judging by how many breaking changes there have been in the go CLI, I wouldn't hold my breath... 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants