-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an end-of-build message #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just wondering if the extra information added isn't going to be more confusing then not.
cmd/xk6/main.go
Outdated
fmt.Println("***************************************************") | ||
fmt.Println("xk6 has now produced a new k6 binary with the following:") | ||
for _, extension := range extensions { | ||
fmt.Println(" -", extension.PackagePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is necessary given that it was just provided as arguments. Especially as if replace
and specific versions were used it might also be a bit confusing - not giving that information here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I was originally thinking to include version as well, but seemed like a potential rabbit-hole for little benefit. 😄
Addresses issue #38
So @mstoykov @imiric, what if we only display a basic message if the For example: NOTE: xk6 has now produced a new k6 binary in <current directoy>.
This _may_ be different than the k6 command on your system path. This will simplify the "edge" cases, but hopefully not be more confusing 😆. For this, I'd add to logger at WARN level. WDYT? |
Turns out the summary is a slippery slope!
8d1a5f0
to
b18f9ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think this will still be helpful.
Although, it's the wrong suggestion on Windows. I think it will fail there...
EDIT: Nevermind, it works fine 🎉:
2nd although 😄: this warning is actually irrelevant on Windows, since all shells run binaries in the CWD first by default and then check the PATH
, so plain k6
(no .\k6
) will run the just built binary. Yeah, huge security risk, but that's Windows... 😅
Addresses issue #38.
Example output:
I didn't add the output to the
log
, preferring plain stdout. WDYT? Timestamps and level just seemed superfluous.