Fix some CLI UX issues #5
Conversation
| @@ -175,7 +182,7 @@ func runDev(ctx context.Context, args []string) error { | |||
| // and since this tool is a carry-through for the user's actual | |||
| // go.mod, we need to transfer their replace directives through | |||
| // to the one we're making | |||
| cmd = exec.Command("go", "list", "-m", "-f={{if .Replace}}{{.Path}} => {{.Replace}}{{end}}", "all") | |||
| cmd = exec.Command("go", "list", "-mod=readonly", "-m", "-f={{if .Replace}}{{.Path}} => {{.Replace}}{{end}}", "all") | |||
There was a problem hiding this comment.
Not sure if this can be considered a fix, but at least it doesn't fail when run from a vendored module directory.
| @@ -94,11 +96,11 @@ The race detector can be enabled by setting `XK6_RACE_DETECTOR=1`. | |||
|
|
|||
| ```go | |||
| builder := xk6.Builder{ | |||
| k6Version: "v2.0.0", | |||
| k6Version: "v0.29.0", | |||
| Plugins: []xk6.Dependency{ | |||
There was a problem hiding this comment.
There's a lot of mention of "plugins" still, but not sure if we should bother with converting them all to "extensions".
There was a problem hiding this comment.
I am for s/plugin/extension/
There was a problem hiding this comment.
Agreed, let's do this in #7.
| return "k6.exe" | ||
| return ".\\k6.exe" | ||
| } | ||
| return "k6" | ||
| return "./k6" |
There was a problem hiding this comment.
I am more inclined to have runDev use a temporary place for the k6 binary instead of overwriting the one in the current directory and then ... possibly deleting it
There was a problem hiding this comment.
I slightly disagree. I get the overwriting/deletion concern, but this is meant to help with quick dev iterations when run from an extension repo, and it's much easier to have the binary in the CWD than in a temp dir somewhere... If you care about where it's written, you should use xk6 build --output instead.
There was a problem hiding this comment.
But ... you delete the file after that ... unless an env variable is set - so in the majority of the cases you will just delete the file 'k6' in the local directory, nothing else.
There was a problem hiding this comment.
Right, and if XK6_SKIP_CLEANUP is set then I'll have to hunt down the binary in a temp dir, which is more annoying than it overwriting/deleting ./k6, that should've been produced by a previous xk6 run anyway.
@na-- Tie breaker? 😄
There was a problem hiding this comment.
The path is literally a few lines above
There was a problem hiding this comment.
I guess we can resolve this later :)
This closes #1, addresses the
PATHissue mentioned in #2 (comment), fixesgo list -m allfor modules with vendored dependencies, and does some README cleanup. It's easier to review by commit, as I didn't want to create 4 separate PRs :)We don't have automated tests for this (maybe we should?), but I confirmed it working as expected locally.