Expose AWS Metrics as an array in update.go #31
Conversation
kgeckhart
requested review from
cristiangreco,
thepalbi,
IfSentient,
ferruvich and
matthewnolf
| Name: "yace_cloudwatch_dmsapi_requests_total", | ||
| Help: "Help is not implemented yet.", | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Should Metrics slice be declared next to the metrics now
There was a problem hiding this comment.
My thought is that update.go is the library entrypoint so if we centralize important pieces of the library API it can make it more discoverable/obvious. We might be the only people using it as a library but might help upstream maintenance as a reminder there's multiple entrypoints. Writing this made think it might be a good idea to add this info to the upstream README. WDYT?
There was a problem hiding this comment.
We might be the only people using it as a library but might help upstream maintenance as a reminder there's multiple entrypoints. Writing this made think it might be a good idea to add this info to the upstream README. WDYT?
+1
This should hopefully make it a lot harder to skip registering a metric, which I already did.
Also deleted the release.yml since it attempts to publish to the upstream repo, 😬
Edit: and adjusted lint + build to run on our live branch