Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return early if no tagged resources are found. #54

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

cristiangreco
Copy link

This adds a check in discoveryJobs after clientTag.get() so that if no
tagged resource is present we return early instead of continuing with
ListMetrics request.

This adds a check in discoveryJobs after clientTag.get() so that if no
tagged resource is present we return early instead of continuing with
ListMetrics request.
Copy link

@kgeckhart kgeckhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

pkg/abstract.go Outdated Show resolved Hide resolved
Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com>
@cristiangreco cristiangreco merged commit 3292863 into live Jun 1, 2022
@cristiangreco cristiangreco deleted the cristian/empty-resources branch June 1, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants