Set max page size for tagging API requests. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tagging API allows specifying the number of resources per page to be returned. Setting it to the max allowed value should reduce the number of requests issued when fetching large fleets of resources. Here we also change the iteration logic to stop at the last page.
cristiangreco
commented
Jun 2, 2022
| @@ -128,6 +128,7 @@ func (iface tagsInterface) get(ctx context.Context, job *Job, region string) ([] | |||
| if len(svc.ResourceFilters) > 0 { | |||
| inputparams := &resourcegroupstaggingapi.GetResourcesInput{ | |||
| ResourceTypeFilters: svc.ResourceFilters, | |||
| ResourcesPerPage: aws.Int64(100), // max allowed value, | |||
There was a problem hiding this comment.
From local testing seems that by default the API will return up to 50 entries per page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tagging API allows specifying the number of resources per page to be
returned. Setting it to the max allowed value should reduce the number
of requests issued when fetching large fleets of resources.
Here we also change the iteration logic to stop at the last page.